committer filter by committer.
@path/to/ filter by path in repository.
committer@path/to/ filter by committer AND path in repository.
abdef0123 filter by commit's SHA hash.
rNNN filter by SVN revision.
rNNN-rMMM filter by SVN revisions range (inclusive).
Multiple filters can be specified separated by spaces or comas in which case they'll be combined using OR operator.
|f4d3aa74||melifaro||Nov. 30, 2022, 1:24 p.m.||netlink: suppress sending NLMSG_ERROR if NLMSG_DONE is already sent
Netlink has a confirmation/error reporting mechanism for the sent messages. Kernel explicitly acks each messages if requested (NLM_F_ACK) or if message processing results in an error. Similarly, for multipart messages - typically dumps, where each message represents a single object like an interface or a route - another message, NLMSG_DONE is used to indicate the end of dump and the resulting status. As a result, successfull dump ends with both NLMSG_DONE and NLMSG_ERROR messages. RFC 3549 does not say anything specific about such case. Linux adopted an optimisation which suppresses NLMSG_ERROR message when NLMSG_DONE is already sent. Certain libraries/applications like libnl depends on such behavior. Suppress sending NLMSG_ERROR if NLMSG_DONE is already sent, by setting newly-added 'suppress_ack' flag in the writer and checking this flag when generating ack. This change restores libnl compatibility. Before: ``` ~ nl-link-list Error: Unable to allocate link cache: Message sequence number mismatch ```` After: ``` ~ nl-link-list vtnet0 ether 52:54:00:14:e3:19 <broadcast,multicast,up,running> lo0 ieee1394 <loopback,multicast,up,running> ``` Reviewed by: bapt,pauamma Tested by: bapt Differential Revision: https://reviews.freebsd.org/D37565cgit
|821549a9||philip||Nov. 30, 2022, 1:50 a.m.||OptionalObsoleteFiles.inc: add zoneinfo/America/Ciudad_Juarez
tzdata 2022g and later split America/Ciudad_Juarez from America/Ojinaga. Ensure this file is removed in builds WITHOUT_ZONEINFO. MFC after: 1 daycgit
|cf1ad535||philip||Nov. 30, 2022, 1:36 a.m.||contrib/tzdata: import tzdata 2022g|
|9f36c6bf||philip||Nov. 30, 2022, 1:31 a.m.||Import tzdata 2022g|
|46d7b45a||gordon||Nov. 29, 2022, 10:51 p.m.||ping: Fix handling of IP packet sizes
Ping reads raw IP packets to parse ICMP responses. When reading the IP Header Len (IHL) ping was was taking the value from the provided packet without any validation. This could lead to remotely triggerable stack corruption. Validate the IHL against expected and recieved data sizes when reading from the received packet and when reading any quoted packets from within the ICMP response. Approved by: so Reviewed by: markj, asomers Security: FreeBSD-SA-22:15.ping Security: CVE-2022-23093 Sponsored by: NetApp, Inc. Sponsored by: Klara, Inc. X-NetApp-PR: #77 Differential Revision: https://reviews.freebsd.org/D37195cgit
|a6d40b0a||kib||Nov. 29, 2022, 10:45 p.m.||libc: remove unneeded sys/types.h include from several synopses
PR: 268028 Reviewed by: kib Discussed with: imp MFC after: 1 weekcgit
|4c4563e3||imp||Nov. 29, 2022, 9:49 p.m.||ofw_net: Use c99 initializers|
|4a8e4d15||bz||Nov. 29, 2022, 9:20 p.m.||net80211: fix IEEE80211_DEBUG_REFCNT builds
Remove the KPI/KBI changes from ieee80211_node.h and always use the macros to pass in __func__ and __LINE__ to the functions. The actual implementations are prefixed by "_" rather than suffixed by "_debug" as they no longer are "debug"-specific. Some of the select functions were not actually using the passed in func, line options; however they are calling other functions which use them. Directly call the internal implementation in those cases passing the arguments on. Use a file-local __debrefcnt_used define to mark the arguments __unused in cases when we compile without IEEE80211_DEBUG_REFCNT and hope the toolchain is intelligent enough to not pass them at all in those cases. Also _ieee80211_free_node() now has a conflict so make the previous _ieee80211_free_node() the new __ieee80211_free_node(). Add IEEE80211_DEBUG_REFCNT to the NOTES file on amd64 to keep exercising the option. Sponsored by: The FreeBSD Foundation X-MFC: never Discussed on: freebsd-wireless Reviewed by: adrian Differential Revision: https://reviews.freebsd.org/D37529cgit
|67d2aaf0||emaste||Nov. 29, 2022, 9:04 p.m.||csh: install hard link with same mode as target
Previously when using NO_ROOT we recorded METALOG entries for the /.cshrc hard link with a different file mode than the link target, which is not permitted. We cannot just set LINKMODE here as it would also apply to the hard link for the tcsh binary. Reviewed by: brooks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D37499cgit
|e59fa9b2||imp||Nov. 29, 2022, 8:11 p.m.||newbus: Comment style nit
Sponsored by: Netflixcgit
|b60164c9||imp||Nov. 29, 2022, 8:10 p.m.||stand/ofw: Use strpbrk instead of two strchrs
No need to call strchr twice, when one call to strpbrk will do the job.. Test booted with qemu-powerpc + mac99 successfully. Minor style(9) tweaks as well. Sponsored by: Netflixcgit
|bc9a5b04||royger||Nov. 29, 2022, 3:36 p.m.||xen/acpi: only evaluate Processor objects matching online CPUs
Current Xen Processor driver will evaluate any Processor object on the ACPI tables regardless of whether the processor is online or not. Avoid doing so for processors that are not online, as evaluating methods of processors that are not online could lead to accesses to invalid memory, and in any case the data that the driver fetches from the Processor ACPI object only makes sense for processors that are online. Note the CPU related data fetched from Xen using XENPF_get_cpuinfo hypercall could be cached, I leave that as a future optimization. Sponsored by: Citrix Systems R&D Fixes: b93f47eaeef7 ('xen/acpi: upload Cx and Px data to Xen')cgit
|bad60285||jrtc27||Nov. 29, 2022, 3:33 a.m.||bsdinstall: Fix local_unbound option default on revisit
The variable used for the checklist's default value needs to correspond to the rc.conf variable as that's what's being parsed to determine them. In the case of local_unbound it's missing the _enable suffix and thus always defaults to off on revisit. Fixes: 58eb9abb3157 ("Add a line to the post-installation configuration dialog to enable the local_unbound service.")cgit
|91985bc5||jrtc27||Nov. 29, 2022, 3:33 a.m.||bsdinstall: Fix issues parsing rc.conf.services on revisit
There are a few issues here, some of which are hiding others. The first is that we don't use double quotes around the command substitution so every word in the conf file is treated as a separate argument to eval, resulting in spaces being used in place of newlines and thus comments in the file commenting out the rest of the file, not just to the end of their line. In particular, we insert one comment just before the dumpdev entry (the final one in the file) and so we never see dumpdev as set, and thus set a default value of on for the menu. The second issue is that, for dumpdev, it takes a value of AUTO not YES when set, but we don't replace this with on when eval'ing, so then end up giving AUTO to bsddialog which is interpreted the same as off (which seems to match GPL dialog). Thus handle AUTO like YES otherwise it will always appear as unchecked on revisit. The final issue is that our case-insensitive YES/NO (and now AUTO) replacements have no word boundaries around them so match the middle of words too. As it happens this doesn't matter in practice at the moment, but it could in future; currently the only effect is that it rewrites moused_nondefault_enable to moused_offndefault_enable, but since this variable is never read, only written based on moused(_enable) this is harmless, but we should fix it in case a service comes along in future that does get affected by it.cgit
|1843da3e||jrtc27||Nov. 29, 2022, 3:33 a.m.||bsdinstall: Fix ntpd_sync_on_start service option
This installer option is currently totally useless, as it ends up creating an ntpd_sync_on_start_enable="YES" entry in rc.conf, not an ntpd_sync_on_start="YES" entry, as is the correct name. This can also be noticed by revisiting the services menu, which parses the previously written rc.conf.services file to set variables governing the default menu entry values so that selecting OK regenerates the same file, as the menu entry will use the correct variable name and thus think the entry was not selected last time, defaulting back to off and losing the setting. Thus, add a special case in the loop for this option. The only other entry that doesn't follow the *_enable pattern is dumpdev (even moused does, it just also sets a second variable), but that also deviates in terms of being explicitly set either way and using AUTO rather than YES, hence why ntpd_sync_on_start follows a different pattern here and is special-cased rather than introducing a whole new variable that governs behaviour outside the loop. Fixes: c153a35bfd71 ("bsdinstall: replace ntpdate by ntpd_sync_on_start")cgit