bcab868a jhb Aug. 17, 2022, 5 p.m.
1b89d40f mjg Aug. 17, 2022, 4:24 p.m.
This reverts commit f6ffed44a8eb5d1ab89a18e60fb056aab2105be7.

fetchadd will fail the waiters flag, which can cause other
code to wait when it should not with nothing clear it

Revert until I sort this out.

Reported by:	markj
e674ddec bz Aug. 17, 2022, 4:11 p.m.
"Invalid TXQ id" and "Queue <n> is stuck <x> <y>" are two errors seen
more commonly by FreeBSD users.  Try to gather some extra data the
"easy way" adding more error logging for these situations in the hope
to find a clue or at least do more targetd debugging in the future.
Note that for one of the errors the Linux Intel driver has a TODO to
print register data.  If that will show up in future versions of the
driver this may also help.

Sponsored by:	The FreeBSD Foundation
MFC after:	3 days
489482e2 glebius Aug. 17, 2022, 3:24 p.m.
Retire PR_LASTHDR protosw flag.

Reviewed by:		ae
Differential revision:	https://reviews.freebsd.org/D36155
05b9737f glebius Aug. 17, 2022, 3:24 p.m.
Reviewed by:		ae, pauamma
Differential revision:	https://reviews.freebsd.org/D36140
e7abb897 kp Aug. 17, 2022, 2:39 p.m.
If hardware vlan tagging is disabled (after a vlan has been added) we
receive double-tagged packets, even if the packet on the wire only has a

single VLAN tag.  That looks like this:

	17:29:30.370787 00:51:82:11:22:02 > 90:ec:77:1f:8a:5f, ethertype 802.1Q (0x8100), length 64: vlan 0, p 0, ethertype 802.1Q, vlan 1001, p 0, ethertype ARP, Ethernet (len 6), IPv4 (len 4), Reply is-at 00:51:82:11:22:02, length 42

This happens because the ixgbe driver does not clear the vlan flags in
the hardware (such as IXGBE_RXDCTL_VME) if IFCAP_VLAN_HWTAGGING is

Add code to do so, which fixes this issue.

Sponsored by:	Rubicon Communications, LLC ("Netgate")
Differential Revision:	https://reviews.freebsd.org/D36139
9ac6eda6 mjg Aug. 17, 2022, 2:23 p.m.
Reviewed by:	markj (previous version)
Differential Revision:	https://reviews.freebsd.org/D36082
60dae3b8 mjg Aug. 17, 2022, 2:21 p.m.
Reviewed by:	markj
Differential Revision:	https://reviews.freebsd.org/D36082
4c2ef8c1 mjg Aug. 17, 2022, 2:20 p.m.
This matches the case using regular buffers and avoids an ifdef later.

Suggested by:	markj
f6ffed44 mjg Aug. 17, 2022, 10:36 a.m.
This also fixes a bug where not-last unbusy failed to post a release

Reviewed by:	markj (previous version), kib (previous version)
Differential Revision:	https://reviews.freebsd.org/D36084
f7413197 antoine Aug. 17, 2022, 8:01 a.m.
6391be30 chuck Aug. 17, 2022, 12:23 a.m.
Switch bzero to memset and bcopy to memcpy

Reviewed by:	imp, jhb
MFC after:	2 weeks
Differential Revision:	https://reviews.freebsd.org/D36215
beeeb40b lwhsu Aug. 17, 2022, 12:15 a.m.
PR:		265889
Fixes:		c04721e35ff0e8220c88d5b10f068dba18629f7e
Sponsored by:	The FreeBSD Foundation
128b0398 mckusick Aug. 16, 2022, 11:46 p.m.
Requested by: Li-Wen Hsu
PR:           261944
Sponsored by: The FreeBSD Foundation
c04721e3 lwhsu Aug. 16, 2022, 10:03 p.m.
This case crashes a bhyve VM.

PR:		265889
Sponsored by:	The FreeBSD Foundation